mik-laj commented on a change in pull request #5694: [AIRFLOW-5082] add subject
in aws sns hook
URL: https://github.com/apache/airflow/pull/5694#discussion_r323979807
##########
File path: airflow/contrib/hooks/aws_sns_hook.py
##########
@@ -53,8 +55,16 @@ def publish_to_target(self, target_arn, message):
'default': message
}
+ if subject is None:
Review comment:
Does this method work without this "if"? For me it should work when the
subject is equal to None. Very often, the default method arguments are None.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
