detvdl commented on PR #42199: URL: https://github.com/apache/airflow/pull/42199#issuecomment-2346624161
> Also do you mind explaining why we explicitely try to `isNaN` the value ? Coercion of isNaN is somewhat surprising, and I' m not sure what we are trying to actually check under the hood. Xcom values are bool, number, obj / null / undefined. `isNaN` returns True for both undefined or NaN so it was mostly a shortcut to check for both From a quick peek at the code I figured both cases could be present exceptionally but I may be wrong, have only looked at the UI rendering for a few minutes. I pragmatically just tackled this specific issue as soon as I saw it, and got a PR out not to forget 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
