gopidesupavan commented on PR #42183: URL: https://github.com/apache/airflow/pull/42183#issuecomment-2347075167
> Thanks for doing this, and I'm sorry I missed the PR; it's been a busy week. Do you think there would be any benefit in expanding this? For example, it might be suitable for a project-level CI check that runs on every provider as part of the PR checks, then everyone can benefit from it. > > Barring that, I wonder if we could move it into some BaseOperatorTests class that these can all inherit so we don't have to manually add it to every service file like this. Make sense, I can add pre-commit script to check using Python ast lib, I feel not possible for all operators , where some of the template_fields are object references example here: https://github.com/apache/airflow/blob/3bc2d3aef6c348e26775f4711ac593acfac9595e/airflow/providers/cncf/kubernetes/operators/job.py#L85, some of them might have to exclude If this sounds Good I can get a pr we can discuss more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
