JoaVirtudes19 commented on code in PR #42268:
URL: https://github.com/apache/airflow/pull/42268#discussion_r1762500921
##########
chart/templates/cleanup/cleanup-cronjob.yaml:
##########
@@ -105,10 +105,17 @@ spec:
env:
{{- include "standard_airflow_environment" . | indent 12 }}
{{- include "container_extra_envs" (list .
.Values.cleanup.env) | indent 12 }}
- volumeMounts: {{- include "airflow_config_mount" . | nindent 16
}}
+ volumeMounts:
+ {{- include "airflow_config_mount" . | nindent 16 }}
+ {{- if .Values.volumeMounts }}
+ {{- toYaml .Values.volumeMounts | nindent 16 }}
+ {{- end }}
resources: {{- toYaml .Values.cleanup.resources | nindent 16 }}
volumes:
- name: config
configMap:
name: {{ template "airflow_config" . }}
+ {{- if .Values.volumes }}
Review Comment:
I think here you could use 'with':
`
{{- with .Values.volumes }}
{{- toYaml . | nindent 12 }}
{{- end }}
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
