Locustv2 opened a new issue, #42273:
URL: https://github.com/apache/airflow/issues/42273

   ### Apache Airflow version
   
   2.10.1
   
   ### If "Other Airflow 2 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   I have a Dag with configuration `retries = 10`.
   One of my custom component (task) ideally should use the Dag configuration 
for retries. But in some cases, this value should be different. So the 
component had default value of `None`
   
   When the default value is used and i try to clear task from the UI, i get an 
error:
   
   ```
   webserver  | [2024-09-14T18:34:43.338+0000] {app.py:1744} ERROR - Exception 
on /clear [POST]
   webserver  | Traceback (most recent call last):
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/flask/app.py", line 2529, in 
wsgi_app
   webserver  | response = self.full_dispatch_request()
   webserver  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/flask/app.py", line 1825, in 
full_dispatch_request
   webserver  | rv = self.handle_user_exception(e)
   webserver  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/flask/app.py", line 1823, in 
full_dispatch_request
   webserver  | rv = self.dispatch_request()
   webserver  | ^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/flask/app.py", line 1799, in 
dispatch_request
   webserver  | return 
self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
   webserver  | 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/auth.py", line 
250, in decorated
   webserver  | return _has_access(
   webserver  | ^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/auth.py", line 
163, in _has_access
   webserver  | return func(*args, **kwargs)
   webserver  | ^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/decorators.py", 
line 159, in wrapper
   webserver  | return f(*args, **kwargs)
   webserver  | ^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/utils/session.py", 
line 97, in wrapper
   webserver  | return func(*args, session=session, **kwargs)
   webserver  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/views.py", line 
2467, in clear
   webserver  | response = self._clear_dag_tis(
   webserver  | ^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/views.py", line 
2343, in _clear_dag_tis
   webserver  | count = dag.clear(
   webserver  | ^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/utils/session.py", 
line 94, in wrapper
   webserver  | return func(*args, **kwargs)
   webserver  | ^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/models/dag.py", line 
2496, in clear
   webserver  | clear_task_instances(
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/models/taskinstance.py",
 line 472, in clear_task_instances
   webserver  | ti.max_tries = ti.try_number + task.retries
   webserver  | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~
   webserver  | TypeError: unsupported operand type(s) for +: 'int' and 
'NoneType'
   webserver  | [2024-09-14T18:34:43.338+0000] {app.py:1744} ERROR - Exception 
on /clear [POST]
   webserver  | Traceback (most recent call last):
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/flask/app.py", line 2529, in 
wsgi_app
   webserver  | response = self.full_dispatch_request()
   webserver  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/flask/app.py", line 1825, in 
full_dispatch_request
   webserver  | rv = self.handle_user_exception(e)
   webserver  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/flask/app.py", line 1823, in 
full_dispatch_request
   webserver  | rv = self.dispatch_request()
   webserver  | ^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/flask/app.py", line 1799, in 
dispatch_request
   webserver  | return 
self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
   webserver  | 
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/auth.py", line 
250, in decorated
   webserver  | return _has_access(
   webserver  | ^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/auth.py", line 
163, in _has_access
   webserver  | return func(*args, **kwargs)
   webserver  | ^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/decorators.py", 
line 159, in wrapper
   webserver  | return f(*args, **kwargs)
   webserver  | ^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/utils/session.py", 
line 97, in wrapper
   webserver  | return func(*args, session=session, **kwargs)
   webserver  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/views.py", line 
2467, in clear
   webserver  | response = self._clear_dag_tis(
   webserver  | ^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/www/views.py", line 
2343, in _clear_dag_tis
   webserver  | count = dag.clear(
   webserver  | ^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/utils/session.py", 
line 94, in wrapper
   webserver  | return func(*args, **kwargs)
   webserver  | ^^^^^^^^^^^^^^^^^^^^^
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/models/dag.py", line 
2496, in clear
   webserver  | clear_task_instances(
   webserver  | File 
"/home/airflow/.local/lib/python3.11/site-packages/airflow/models/taskinstance.py",
 line 472, in clear_task_instances
   webserver  | ti.max_tries = ti.try_number + task.retries
   webserver  | ~~~~~~~~~~~~~~^~~~~~~~~~~~~~
   webserver  | TypeError: unsupported operand type(s) for +: 'int' and 
'NoneType'
   ``` 
   
   ### What you think should happen instead?
   
   Ideally if `None` is used at Task level, the default Dag configuration 
should be used and when a value is provided, it overrides the Dag config.
   
   ### How to reproduce
   
   - Set retries at Dag configuration, and then within a task/operator, set 
`retries = None`.
   - Run the dag
   - try to clear task 
   - error happens
   
   ### Operating System
   
   MacOS Sonoma
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Other
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to