topherinternational commented on PR #41717: URL: https://github.com/apache/airflow/pull/41717#issuecomment-2355535387
I simplified the failing sensor test which was added by someone else in a different PR. Now it mocks the MongoHook and only tests the interactions between the sensor code and the hook instance inside the sensor, the details of connections etc are not necessary to confirm the sensor is working as designed. (IMO if we do want to test more realistically, we should use mongomock to mock the Mongo endpoint, and have real non-mocked MongoHook and Connection objects, but that's beyond the scope of this PR). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
