Ariel2400 commented on code in PR #42275:
URL: https://github.com/apache/airflow/pull/42275#discussion_r1763215516
##########
airflow/providers/common/sql/operators/sql.py:
##########
@@ -221,7 +221,7 @@ def __init__(
sql: str | list[str],
autocommit: bool = False,
parameters: Mapping | Iterable | None = None,
- handler: Callable[[Any], Any] = fetch_all_handler,
+ handler: Callable[[Any], Iterable[Tuple]] = fetch_all_handler,
Review Comment:
Why optional? If there's no results it will return an empty list. I agree
that it should be a list, will change the Iterable to List
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
