jedcunningham commented on code in PR #41804:
URL: https://github.com/apache/airflow/pull/41804#discussion_r1745886470
##########
airflow/providers/fab/migrations/versions/0001_1_3_0_placeholder_migration.py:
##########
Review Comment:
Hmm, why do we need a placeholder?
##########
airflow/cli/commands/db_command.py:
##########
@@ -115,9 +125,10 @@ def migratedb(args):
parsed_version = parse_version(args.from_version)
except InvalidVersion:
raise SystemExit(f"Invalid version {args.from_version!r} supplied
as `--from-version`.")
- if parsed_version < parse_version("2.0.0"):
- raise SystemExit("--from-version must be greater or equal to than
2.0.0")
- from_revision = get_version_revision(args.from_version)
+ if airflow_db:
+ if parsed_version < parse_version("2.0.0"):
+ raise SystemExit("--from-version must be greater or equal to
than 2.0.0")
Review Comment:
Probably should move this to `migratedb`, then we can rename `airflow_db` ->
`reserialize_dags` which is a little more generic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
