dennysrega1ado commented on issue #36842:
URL: https://github.com/apache/airflow/issues/36842#issuecomment-2359261403

   @idantepper 
   Here’s the updated version of your message, emphasizing your uncertainty 
about the existing script and the potential issues with the ER diagram source:
   
   ---
   
   I’ve just created a [draft PR](https://github.com/apache/airflow/pull/42323) 
in my repository and have some questions:
   
   1. The `update-er-diagram` pre-commit function generates the 
`docs/apacha-airflow/img/airflow_erd.svg` file.
      - Should we keep this existing script or replace it? I’m unsure whether 
to continue with the current approach or switch to a new one.
      - The current ER diagram is generated from the database after migrations 
are applied. The new approach would generate the diagram solely from model 
definitions, potentially excluding changes made after migrations. Does this 
make sense, or should we include the post-migration changes in the ER diagram?
   
   2. Would it be beneficial to inject the Mermaid code into the README file so 
we can use GitHub’s built-in viewer?
   
   I understand this issue isn’t assigned to me, but I’m exploring this path. 
If any of my changes seem viable, I’d appreciate some guidance to help me move 
forward, as I’m feeling a bit lost.
   
   Thanks!
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to