Lee-W commented on code in PR #41348: URL: https://github.com/apache/airflow/pull/41348#discussion_r1766553587
########## tests/providers/amazon/aws/assets/test_s3.py: ########## @@ -20,13 +20,13 @@ import pytest -from airflow.datasets import Dataset -from airflow.providers.amazon.aws.datasets.s3 import ( - convert_dataset_to_openlineage, - create_dataset, +from airflow.providers.amazon.aws.assets.s3 import ( Review Comment: > Can you please make the changes in a way that tests are also able to run with Airflow 2.8-2.10? I think this should work fine for 2.8-2.10. We're running the tests against those versions as well. I fixed most of them > Besides this we also decided to have provider PRs always spearate from Core changes allowing to cherry-pick if needed. I'm not sure we're able to do that for this one. If we make core changes without changing the provider, it breaks the tests. We need to change the core, and the providers (with backward compact) all alone. Some of the backward compact will be added to common.compat providers. Once released, we'll remove the duplicate code and use the logic in common.compat provider -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
