Avihais12344 commented on code in PR #42348:
URL: https://github.com/apache/airflow/pull/42348#discussion_r1766750394
##########
chart/templates/_helpers.yaml:
##########
@@ -336,7 +336,14 @@ If release name contains chart name it will be used as a
full name.
{{- end }}
{{- define "pod_template_image" -}}
- {{- printf "%s:%s" (.Values.images.pod_template.repository | default
.Values.defaultAirflowRepository) (.Values.images.pod_template.tag | default
.Values.defaultAirflowTag) }}
+ {{- $repository := .Values.images.pod_template.repository | default
.Values.defaultAirflowRepository -}}
+ {{- $tag := .Values.images.pod_template.tag | default
.Values.defaultAirflowTag -}}
+ {{- $digest := .Values.images.pod_template.digest | default
.Values.defaultAirflowDigest -}}
+ {{- if $digest }}
+ {{- printf "%s@%s" $repository $digest -}}
+ {{- else }}
+ {{- printf "%s:%s" $repository $tag -}}
+ {{- end }}
Review Comment:
I think that if we already fix this, we should also check if there's a tag,
and if both (digest and tag) are missing, it would raise an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
