jedcunningham commented on code in PR #42320: URL: https://github.com/apache/airflow/pull/42320#discussion_r1768956574
########## airflow/api_fastapi/parameters.py: ########## @@ -0,0 +1,165 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +from __future__ import annotations + +from abc import ABC, abstractmethod +from typing import Any, Generic, List, TypeVar, Union + +from fastapi import Depends, HTTPException, Query as Query +from sqlalchemy import or_ +from sqlalchemy.sql import ColumnElement, Select +from typing_extensions import Annotated, Self + +from airflow.models.dag import DagModel, DagTag + +T = TypeVar("T") + + +class BaseParam(Generic[T], ABC): + """Base class for filters.""" + + def __init__(self) -> None: + self.value: T | None = None + self.attribute: ColumnElement | None = None + + @abstractmethod + def to_orm(self, select: Select) -> Select: + pass + + @abstractmethod + def __call__(self, *args: Any, **kwarg: Any) -> BaseParam: + pass + + def set_value(self, value: T) -> Self: + self.value = value + return self + + +class _LimitFilter(BaseParam[int]): + """Filter on the limit.""" + + def to_orm(self, select: Select) -> Select: + if self.value is None: + return select + + return select.limit(self.value) + + def __call__(self, limit: int = 100) -> _LimitFilter: + self.value = limit + + return self Review Comment: ```suggestion return self.set_value(limit) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
