shahar1 commented on PR #41561:
URL: https://github.com/apache/airflow/pull/41561#issuecomment-2365040705

   > @shahar1 sir and @vincbeck sir I've tried to resolve conflict and done my 
best to cover the expected behaviors. As I'm a beginner, I'd greatly appreciate 
your feedback and any suggestions for improvement but i am stuck in resolving 
these errors please sir can you guide me to resolve these issue
   
   Take a look at this part:
   ```python
           mock_defer.assert_called_once_with(
               trigger=EmrCreateJobFlowTrigger( # <- New instance
                   job_flow_id=JOB_FLOW_ID,
                   aws_conn_id=self.operator.aws_conn_id,
                   waiter_delay=self.operator.waiter_delay,
                   waiter_max_attempts=self.operator.waiter_max_attempts,
               ),
               method_name="execute_complete",
               timeout=timedelta(seconds=self.operator.waiter_max_attempts * 
self.operator.waiter_delay + 60),
           )
   ```
   
   As I previously wrote, here you create a new instance of 
`EmrCreateJobFlowTrigger` - which means that it will always be different than 
the instance created within the 
[trigger](https://github.com/apache/airflow/blob/3cea4fdc9e5ff55c0fb87d3f57e0be3fba520f28/airflow/providers/amazon/aws/operators/emr.py#L833)
 attribute of `defer()`. Try to find a way to patch the creation of this 
instance, so they'll become the same entity.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to