Lee-W commented on code in PR #42403:
URL: https://github.com/apache/airflow/pull/42403#discussion_r1770837820


##########
dev/breeze/doc/01_installation.rst:
##########
@@ -234,8 +234,19 @@ In case of disk space errors on macOS, increase the disk 
space available for Doc
 
 Installation
 ============
+First, clone the Airflow repository, but ensure you do not clone it into your 
home directory. Doing so will trigger the following error:
+'Your Airflow sources are checked out in /Users/username/airflow, which is 
also your AIRFLOW_HOME where Airflow writes logs and database files. This setup 
is problematic because Airflow might overwrite or clean up your source code and 
.git repository.'

Review Comment:
   ```suggestion
   `Your Airflow sources are checked out in /Users/username/airflow, which is 
also your AIRFLOW_HOME where Airflow writes logs and database files. This setup 
is problematic because Airflow might overwrite or clean up your source code and 
.git repository.`
   ```



##########
dev/breeze/doc/01_installation.rst:
##########
@@ -234,8 +234,19 @@ In case of disk space errors on macOS, increase the disk 
space available for Doc
 
 Installation
 ============
+First, clone the Airflow repository, but ensure you do not clone it into your 
home directory. Doing so will trigger the following error:

Review Comment:
   ```suggestion
   First, clone the Airflow repository, but make sure not to clone it into your 
home directory. Cloning it into your home directory will cause the following 
error:
   ```



##########
dev/breeze/doc/01_installation.rst:
##########
@@ -234,8 +234,19 @@ In case of disk space errors on macOS, increase the disk 
space available for Doc
 
 Installation
 ============
+First, clone the Airflow repository, but ensure you do not clone it into your 
home directory. Doing so will trigger the following error:
+'Your Airflow sources are checked out in /Users/username/airflow, which is 
also your AIRFLOW_HOME where Airflow writes logs and database files. This setup 
is problematic because Airflow might overwrite or clean up your source code and 
.git repository.'
+
+.. code-block:: bash
+
+    git clone https://github.com/apache/airflow.git
+
+Then set your working directory to root of (this) cloned repository.

Review Comment:
   ```suggestion
   Set your working directory to the root of this cloned repository.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to