uranusjr commented on code in PR #42404:
URL: https://github.com/apache/airflow/pull/42404#discussion_r1770877938


##########
airflow/providers/cncf/kubernetes/executors/kubernetes_executor.py:
##########
@@ -117,7 +117,7 @@
         help="Generate YAML files for all tasks in DAG. Useful for debugging 
tasks without "
         "launching into a cluster",
         
func=lazy_load_command("airflow.providers.cncf.kubernetes.cli.kubernetes_command.generate_pod_yaml"),
-        args=(ARG_DAG_ID, ARG_EXECUTION_DATE, ARG_SUBDIR, ARG_OUTPUT_PATH, 
ARG_VERBOSE),
+        args=(ARG_DAG_ID, ARG_LOGICAL_DATE, ARG_SUBDIR, ARG_OUTPUT_PATH, 
ARG_VERBOSE),

Review Comment:
   We need a try-except to support 2.x, something like
   
   ```python
   try:
       from airflow.cli.cli_config import ARG_LOGICAL_DATE
   except ImportError:  # 2.x compatibility.
       from airflow.cli.cli_config import ARG_EXECUTION_DATE as ARG_LOGICAL_DATE
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to