uranusjr commented on code in PR #42343:
URL: https://github.com/apache/airflow/pull/42343#discussion_r1772888064
##########
airflow/datasets/manager.py:
##########
@@ -58,12 +58,55 @@ class DatasetManager(LoggingMixin):
def __init__(self, **kwargs):
super().__init__(**kwargs)
- def create_datasets(self, dataset_models: list[DatasetModel], session:
Session) -> None:
+ def create_datasets(self, datasets: list[Dataset], *, session: Session) ->
list[DatasetModel]:
"""Create new datasets."""
- for dataset_model in dataset_models:
- session.add(dataset_model)
- for dataset_model in dataset_models:
- self.notify_dataset_created(dataset=Dataset(uri=dataset_model.uri,
extra=dataset_model.extra))
+
+ def _add_one(dataset: Dataset) -> DatasetModel:
+ model = DatasetModel.from_public(dataset)
+ session.add(model)
+ return model
+
+ models = [_add_one(d) for d in datasets]
+ for dataset in datasets:
+ self.notify_dataset_created(dataset=dataset)
Review Comment:
We had two choices when we did this (to flush or not to flush before calling
the hook). Was there a particular reason one was chosen instead of the other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
