romsharon98 commented on code in PR #42285:
URL: https://github.com/apache/airflow/pull/42285#discussion_r1773274542


##########
airflow/models/baseoperator.py:
##########
@@ -975,7 +965,6 @@ def __init__(
         if self.pool_slots < 1:
             dag_str = f" in dag {dag.dag_id}" if dag else ""
             raise ValueError(f"pool slots for {self.task_id}{dag_str} cannot 
be less than 1")
-        self.sla = sla

Review Comment:
   because todays sla is also for tasks so we should add a deprecation warning 
here also.
   and this will be the last deprecation warning needed to add.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to