mik-laj commented on a change in pull request #6093: [AIRFLOW-5475] Normalize
gcp_conn_id in operators and hooks
URL: https://github.com/apache/airflow/pull/6093#discussion_r324406927
##########
File path: airflow/gcp/hooks/gcs.py
##########
@@ -42,11 +43,20 @@ class GoogleCloudStorageHook(GoogleCloudBaseHook):
_conn = None # type: Optional[storage.Client]
- def __init__(self,
- google_cloud_storage_conn_id='google_cloud_default',
- delegate_to=None):
- super().__init__(google_cloud_storage_conn_id,
- delegate_to)
+ def __init__(
+ self,
+ gcp_conn_id: str = 'google_cloud_default',
+ delegate_to: Optional[str] = None,
+ google_cloud_storage_conn_id: Optional[str] = None
+ ) -> None:
+ # To preserve backward compatibility
+ # TODO: remove one day
+ if google_cloud_storage_conn_id:
+ warnings.warn(
+ "The google_cloud_storage_conn_id parameter has been
deprecated. You should pass "
Review comment:
Isn't stack level missing here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
