jscheffl commented on code in PR #41348:
URL: https://github.com/apache/airflow/pull/41348#discussion_r1774069989
##########
docs/apache-airflow/img/asset-scheduled-dags.png:
##########
Review Comment:
Does the screenshot not need to have an update? The tag is still named
"dataset" :-D
##########
airflow/providers/amazon/aws/auth_manager/aws_auth_manager.py:
##########
@@ -161,15 +158,12 @@ def is_authorized_dag(
context=context,
)
- def is_authorized_dataset(
Review Comment:
+1 breaking change?
##########
docs/apache-airflow/img/assets.png:
##########
Review Comment:
+1 Screenshot refresh needed?
##########
airflow/providers/amazon/aws/auth_manager/avp/entities.py:
##########
Review Comment:
+1 breaking change here - Are we sure we can make the auth manager working
with Airflow 2.10 with the `DATASET` constant removed?
##########
airflow/providers/amazon/aws/assets/s3.py:
##########
Review Comment:
Understood from previous comment response that it is required to change both
providers and core here. But this very much smells like a breaking change in
provider. Is is acceptable for the Airflow 2.10 community use?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
