Lee-W commented on code in PR #42490:
URL: https://github.com/apache/airflow/pull/42490#discussion_r1776490232
##########
airflow/providers/common/sql/hooks/sql.py:
##########
@@ -210,6 +210,17 @@ def connection(self) -> Connection:
self._connection = self.get_connection(self.get_conn_id())
return self._connection
+ @connection.setter
+ def connection(self, value: Any) -> None:
+ # This dummpy setter is for backward compatibility and should not be
used.
+ # Since the introduction of connection property, the providers listed
below
+ # breaks due to assigning value to self.connection
+ #
+ # apache-airflow-providers-mysql<5.7.1
+ # apache-airflow-providers-elasticsearch<5.5.1
+ # apache-airflow-providers-postgres<5.13.0
+ pass
Review Comment:
they still have `self.connection = ...`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
