romsharon98 commented on code in PR #42427:
URL: https://github.com/apache/airflow/pull/42427#discussion_r1778513963
##########
airflow/providers/cncf/kubernetes/operators/spark_kubernetes.py:
##########
@@ -166,7 +165,7 @@ def create_job_name(self):
updated_name = add_unique_suffix(name=name, max_len=MAX_LABEL_LEN)
- return re.sub(r"[^a-z0-9-]+", "-", updated_name.lower())
+ return self._set_name(updated_name.lower())
Review Comment:
I think you don't have to do `lower()` it will do it in the function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
