R7L208 commented on code in PR #42668: URL: https://github.com/apache/airflow/pull/42668#discussion_r1793817565
########## airflow/providers/databricks/exceptions.py: ########## @@ -0,0 +1,32 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# Note: Any AirflowException raised is expected to cause the TaskInstance +# to be marked in an ERROR state +"""Exceptions used by Databricks Provider.""" + +from __future__ import annotations + +from airflow.exceptions import AirflowException + + +class AirflowTaskExecutionError(AirflowException): + """Raised when there is an error in task execution.""" + + +class AirflowTaskExecutionTimeout(AirflowTaskExecutionError): + """Raised when a task execution times out.""" Review Comment: I'm not opposed, but I've been trying to follow similar patterns and styles to other providers. I've not seen provider-specific exceptions, which primarily just use AirflowException directly. @Lee-W Let me know your thoughts on this and happy to adjust the code according -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
