ashb commented on code in PR #42761:
URL: https://github.com/apache/airflow/pull/42761#discussion_r1795033563
##########
providers/tests/google/cloud/transfers/test_facebook_ads_to_gcs_system.py:
##########
@@ -26,12 +26,13 @@
from airflow.exceptions import AirflowException
from airflow.models import Connection
from airflow.utils.process_utils import patch_environ
+from providers.src.airflow.providers.google.cloud.example_dags import
example_facebook_ads_to_gcs
Review Comment:
```suggestion
from airflow.providers.google.cloud.example_dags import
example_facebook_ads_to_gcs
```
(And then imports'll need re-ordering)
##########
providers/tests/system/google/cloud/dataprep/example_dataprep.py:
##########
@@ -313,6 +313,13 @@ def delete_connection(connection_id: str) -> None:
# when "tearDown" task with trigger rule is part of the DAG
list(dag.tasks) >> watcher()
+
+from dev.tests_common.test_utils.system_tests import get_test_run # noqa: E402
+
+# Needed to run the example DAG with pytest (see:
tests/system/README.md#run_via_pytest)
+test_run = get_test_run(dag)
Review Comment:
Something in the pre-commit made this a duplicated block -- it already
exists a few lines below.
##########
providers/src/airflow/providers/google/marketing_platform/example_dags/example_display_video.py:
##########
@@ -125,7 +125,7 @@
"example_display_video_sdf",
start_date=START_DATE,
catchup=False,
-) as dag3:
+) as dag_example_display_video_sdf:
Review Comment:
Nit: unrelated changes in this file
##########
providers/tests/google/cloud/operators/test_datastore_system.py:
##########
@@ -44,8 +44,8 @@ def teardown_method(self):
@provide_gcp_context(GCP_DATASTORE_KEY)
def test_run_example_dag(self):
- self.run_dag("example_gcp_datastore", CLOUD_DAG_FOLDER)
+ self.run_dag("example_gcp_datastore", CLOUD_DAG_FOLDER) # this dag
does not exist?
@provide_gcp_context(GCP_DATASTORE_KEY)
def test_run_example_dag_operations(self):
- self.run_dag("example_gcp_datastore_operations", CLOUD_DAG_FOLDER)
+ self.run_dag("example_gcp_datastore_operations", CLOUD_DAG_FOLDER) #
this dag does not exist?
Review Comment:
How on earth have these tests been passing? I guess they haven't as we don't
regularly run these system tests?
These dags were removed/moved/renamed in
https://github.com/apache/airflow/pull/23108 by @bhirsz.
I guess the google system tests can't have been fully run since 2022 then.
Yay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
