[
https://issues.apache.org/jira/browse/AIRFLOW-5489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16930115#comment-16930115
]
ASF subversion and git services commented on AIRFLOW-5489:
----------------------------------------------------------
Commit 52c6516509ea40493b888aad08f49961635f5fc8 in airflow's branch
refs/heads/master from getras1998
[ https://gitbox.apache.org/repos/asf?p=airflow.git;h=52c6516 ]
AIRFLOW-5489: Remove unneeded assignment of variable (#6106)
> bash_senor: Remove unneeded assignment of variable
> --------------------------------------------------
>
> Key: AIRFLOW-5489
> URL: https://issues.apache.org/jira/browse/AIRFLOW-5489
> Project: Apache Airflow
> Issue Type: Bug
> Components: operators
> Affects Versions: 1.10.6
> Reporter: Jakob Homan
> Priority: Minor
> Labels: ccoss2019, newbie
>
> Note: This ticket's being created to facilitate a new contributor's workshop
> for Airflow. After the workshop has completed, I'll mark these all available
> for anyone that might like to take them on.
> The `line` variable is assigned to `''` but then immediately reassigned in
> the loop. This first assignment should be deleted.
> airflow/contrib/sensors/bash_sensor.py:83
> {code:java}
> line = ''
> for line in iter(sp.stdout.readline, b''):
> line = line.decode(self.output_encoding).strip()
> self.log.info(line)
> sp.wait()
> self.log.info("Command exited with return code %s", sp.returncode) {code}
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
