RNHTTR commented on code in PR #42005:
URL: https://github.com/apache/airflow/pull/42005#discussion_r1797362428
##########
airflow/models/baseoperator.py:
##########
@@ -909,6 +909,7 @@ def __init__(
task_display_name: str | None = None,
logger_name: str | None = None,
allow_nested_operators: bool = True,
+ call_on_kill_on_dagrun_timeout: bool = True,
Review Comment:
This all stems from the fairly controversial idea of [setting running tasks
to skipped if a DAG run reaches its
timeout](https://github.com/apache/airflow/issues/30264).
There are a couple paths forward:
1. Change the behavior after a `dagrun_timeout` is reached to mark running
TIs as failed.
1. Proceed with this PR
2. Encourage users to use an
[on_skipped_callback](https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/logging-monitoring/callbacks.html#callback-types)
for external systems that need to be shutdown when a task moves to the skipped
state after a DAG run timeout.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
