jscheffl commented on PR #35591: URL: https://github.com/apache/airflow/pull/35591#issuecomment-2408040683
Oh, this is a longer thread. Took a moment to read it through. As this PR is currently constructed it can not be merged - as we decided that Provider and Core changes need to be separated (See https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md#developing-for-providers-and-helm-chart). Besides this (even if the PR is split between core and provider) the changes add a cross depency, the provider will only work with the Core adjustments (because the additional connection fields only will be accepted by a new core) and this would be a problem supporting old airflow versions. And the other way around, yes the changes in core would require to be in Airflow 3.0. Whereas the facility for extended connection fields is to be re-worked and to be designed - not there today. I would not like to add features on the legacy, this would make the migration harder and changed anyway would never be released. So I assume - even though the extensions look nice (not considering the security limits we need to cut off) it would need to be parked until all required mechanisms are in place for Airflow 3. Would it make sense to "strip" the PR down to be 100% compliant to Airflow 2.8++? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
