jscheffl commented on code in PR #42929:
URL: https://github.com/apache/airflow/pull/42929#discussion_r1797375319
##########
airflow/api_fastapi/views/public/variables.py:
##########
@@ -56,3 +56,27 @@ async def get_variable(
raise HTTPException(404, f"The Variable with key: `{variable_key}` was
not found")
return VariableResponse.model_validate(variable, from_attributes=True)
+
+
+@variables_router.patch("/{variable_key}",
responses=create_openapi_http_exception_doc([400, 401, 403, 404]))
+async def patch_variable(
+ variable_key: str,
+ patch_body: VariableBody,
Review Comment:
Do I see it right that the variable key is sent with the URL and is
additionally/redundantly contained in the body of the POST? (I see at least
this is consistent to the existing API...) Would we need to cross check the
content for consistency? Or is it a feature that I have "a" as key in the URL
abd "b" in the body?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
