potiuk commented on code in PR #42967:
URL: https://github.com/apache/airflow/pull/42967#discussion_r1797902315
##########
dev/breeze/src/airflow_breeze/commands/ci_image_commands.py:
##########
@@ -296,6 +297,7 @@ def get_exitcode(status: int) -> int:
@option_debug_resources
@option_dev_apt_command
@option_dev_apt_deps
+@option_disable_airflow_repo_cache
Review Comment:
Comment: CI image build command did not handle --disable-airflow-repo-cache
flag. It was only handled in PROD build.
##########
dev/breeze/src/airflow_breeze/commands/common_image_options.py:
##########
@@ -108,13 +108,20 @@
help="Apt dev dependencies to use when building the images.",
envvar="DEV_APT_DEPS",
)
+option_disable_airflow_repo_cache = click.option(
+ "--disable-airflow-repo-cache",
+ help="Disable cache from Airflow repository during building.",
+ is_flag=True,
+ envvar="DISABLE_AIRFLOW_REPO_CACHE",
+)
option_docker_cache = click.option(
"-c",
"--docker-cache",
help="Cache option for image used during the build.",
default=ALLOWED_BUILD_CACHE[0],
show_default=True,
type=BetterChoice(ALLOWED_BUILD_CACHE),
+ envvar="DOCKER_CACHE",
Review Comment:
Comment: DOCKER_CACHE variable was not treated as --docker-cache flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
