gopidesupavan commented on PR #42971: URL: https://github.com/apache/airflow/pull/42971#issuecomment-2408799673
> No. That is generally bad idea to have `tests_common` in `dev` (and this case shows why). > > Dev is indeed replaced in CI when images - in "checkout target commit": > > ```shell > echo > echo -e "\033[33m Replace scripts, dev, actions with target branch for non-committer builds!\033[0m" > echo > rm -rfv "scripts/ci" > rm -rfv "dev" > rm -rfv ".github/actions" > rm -rfv ".github/workflows" > mv -v "target-airflow/scripts/ci" "scripts" > mv -v "target-airflow/dev" "." > mv -v "target-airflow/.github/actions" "target-airflow/.github/workflows" ".github" > ``` > > This is for security reason, so that any of the "dev" scripts that are used during CI and build process are not tampered with when they are modified in the incoming PR. > > This is a bit of a teething problem after #42505 and you were the unlucky first non-committer who attempted to modify common test code that is shared between providers and airflow. > > @ashb - we will have to find better place for "tests_common" than `dev` - because otherwise every non-commiter who wants to make a PR changing the "common" code they will get their "dev/tests_common" code overwritten. > > Generally "dev" was always supposed to be used for "build scripts" but never by "test code". > > How about just "tests_common" at the top level of the repository @ashb ? Thanks jarek I agree , sorry for this :( previously it was in different location. So thought might be because of restructure it moved... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
