potiuk commented on issue #42989:
URL: https://github.com/apache/airflow/issues/42989#issuecomment-2410874018

   > @potiuk , I think, "lower bound" was given as an example in the warnings.~~
   > 
   > For example, asgiref is currently set to be `"asgiref>=2.3.0",` in 
hatch_build.py.
   > 
   > ~Looks like, the issue is with constraints.txt and that's where we need to 
put the lowerbound~
   > 
   > @potiuk, I'm a bit confused here. All of the pins in constraints.txt use 
exact matches (`==`). Not sure where the issue is. I tried to set an upper 
bound to asgiref and yet uv is printing same warning
   
   Interesting. Worth taking a closer look. Constraints do not matter here. 
When we use "lowest-direct", we do not use constraints at all. Those are only 
used when we (or our users) want to reproducibly install airflow, but for 
`--resolution lowest-direct` we do not specify constraints (and it would make 
no sense) - we let `uv` lower all dependencies matching the requirements.
   
   I think the asgiref warning comes from http provider dependencies (see 
provider.yaml for http provider)
   
   ```
   dependencies:
     - apache-airflow>=2.8.0
     # The 2.26.0 release of requests got rid of the chardet LGPL mandatory 
dependency, allowing us to
     # release it as a requirement for airflow
     - requests>=2.27.0,<3
     - requests_toolbelt
     - aiohttp>=3.9.2
     - asgiref
    ```
   
   I think fix for that particular one will be to make sure all asgiref 
dependencies we have use the same lower-bound.
   
   BTW. It's also surprising to see asgiref as http provider dependencies - so 
maybe we should take a look if it is needed at all @rawwar :) ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to