potiuk commented on PR #42945: URL: https://github.com/apache/airflow/pull/42945#issuecomment-2412456863
> Hi @potiuk , it seems like typo in my repair run PR, I have tested on our dev, for deferrable, it is working as expected, but in normal, it is failing, you can find error in screenshot below, thanks Which PR? And I think in either case - if this is "correct fix" - generally speaking we do not accept PRs like that which have no unit test changes - because it means that the "bad" functionality did not have a good unit test. If it did, the test would fail after your change and you would have to correct the test as well) - so adding a unit test here is pretty much mandatory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
