mobuchowski commented on code in PR #42081: URL: https://github.com/apache/airflow/pull/42081#discussion_r1800747911
########## providers/src/airflow/providers/amazon/aws/operators/appflow.py: ########## @@ -21,12 +21,16 @@ from typing import TYPE_CHECKING, cast from airflow.exceptions import AirflowException -from airflow.operators.python import ShortCircuitOperator from airflow.providers.amazon.aws.hooks.appflow import AppflowHook from airflow.providers.amazon.aws.operators.base_aws import AwsBaseOperator from airflow.providers.amazon.aws.utils import datetime_to_epoch_ms from airflow.providers.amazon.aws.utils.mixins import AwsBaseHookMixin, AwsHookParams, aws_template_fields +try: + from airflow.providers.standard.operators.python import ShortCircuitOperator +except ImportError: + from airflow.operators.python import ShortCircuitOperator # type: ignore[no-redef,attr-defined] Review Comment: Maybe add those imports to `compat` provider and then you wouldn't have to try/except everywhere? The drawback is you'd need to add dependency to `compat` providers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
