eilon246810 opened a new pull request, #43050:
URL: https://github.com/apache/airflow/pull/43050
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
##What is this PR about
I removed an emoji from breeze's README.md file.
It caused me problems running breeze and I think it may happened to others
too.
Also it's not necessary.
<details>
<summary>The Error I Got</summary>
I happens when python is trying to read the breeze readme and fails due to
`UnicodeDecodeError`.
```
Traceback (most recent call last):
File
"C:\Users\Eilon\AppData\Local\Programs\Python\Python310-32\lib\runpy.py", line
196, in _run_module_as_main
return _run_code(code, main_globals, None,
File
"C:\Users\Eilon\AppData\Local\Programs\Python\Python310-32\lib\runpy.py", line
86, in _run_code
exec(code, run_globals)
File
"C:\Users\Eilon\pipx\venvs\apache-airflow-breeze\Scripts\breeze.exe\__main__.py",
line 4, in <module>
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\breeze.py",
line 20, in <module>
from airflow_breeze.commands.main_command import main
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\commands\main_command.py",
line 25, in <module>
from airflow_breeze.commands.ci_image_commands import ci_image
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\commands\ci_image_commands.py",
line 32, in <module>
from airflow_breeze.commands.common_image_options import (
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\commands\common_image_options.py",
line 23, in <module>
from airflow_breeze.global_constants import (
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\global_constants.py",
line 30, in <module>
from airflow_breeze.utils.path_utils import AIRFLOW_SOURCES_ROOT
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\utils\path_utils.py",
line 281, in <module>
AIRFLOW_SOURCES_ROOT =
find_airflow_sources_root_to_operate_on().resolve()
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\utils\path_utils.py",
line 266, in find_airflow_sources_root_to_operate_on
reinstall_if_setup_changed()
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\utils\path_utils.py",
line 180, in reinstall_if_setup_changed
process_breeze_readme(breeze_sources, sources_hash)
File
"C:\Users\Eilon\Programming\python\open_source\airflow\dev\breeze\src\airflow_breeze\utils\path_utils.py",
line 149, in process_breeze_readme
lines = breeze_readme.read_text().splitlines(keepends=True)
File
"C:\Users\Eilon\AppData\Local\Programs\Python\Python310-32\lib\pathlib.py",
line 1133, in read_text
return f.read()
File
"C:\Users\Eilon\AppData\Local\Programs\Python\Python310-32\lib\encodings\cp1252.py",
line 23, in decode
return codecs.charmap_decode(input,self.errors,decoding_table)[0]
UnicodeDecodeError: 'charmap' codec can't decode byte 0x8f in position 2143:
character maps to <undefined>
```
</details>
<!-- Please keep an empty line above the dashes. -->
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
