pierrejeambrun commented on code in PR #42973:
URL: https://github.com/apache/airflow/pull/42973#discussion_r1802543008


##########
airflow/api_fastapi/routes/public/dag_run.py:
##########
@@ -57,3 +57,19 @@ async def delete_dag_run(dag_id: str, dag_run_id: str, 
session: Annotated[Sessio
         )
 
     session.delete(dag_run)
+
+
+@dag_run_router.patch("/{dag_run_id}", 
responses=create_openapi_http_exception_doc([400, 401, 403, 404]))

Review Comment:
   In the legacy api this is a `PUT` I believe. Also it is really dedicated to 
the `update_dag_run_state`. It is not a general 'patch_dag_run`.
   
   `@dag_run_router.put`
   
   A general `PATCH` would be missing the `update_mask` etc... (cf legacy and 
other PATCH endpoints)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to