ashb commented on code in PR #43040:
URL: https://github.com/apache/airflow/pull/43040#discussion_r1802910508


##########
airflow/settings.py:
##########
@@ -118,6 +118,27 @@
     "upstream_failed": "orange",
 }
 
+# list of the environment variables that need to be masked from the logs
+# some of these could be sensitive and there's no reason to log those
+ENV_VARIABLES_TO_MASK = [
+    "AIRFLOW__CORE__FERNET_KEY",
+    "AIRFLOW__SMTP__SMTP_PORT",
+    "AIRFLOW__SMTP__SMTP_PASSWORD",

Review Comment:
   This list feels wrong to hard code. I'm fairly sure there is already a 
concept in the configuration of a "sensitive" config which we should reuse.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to