kaxil commented on code in PR #43015:
URL: https://github.com/apache/airflow/pull/43015#discussion_r1804537840
##########
airflow/cli/commands/fastapi_api_command.py:
##########
@@ -81,16 +82,22 @@ def fastapi_api(args):
str(args.hostname),
]
+ # There is no way to pass the apps to airflow/api_fastapi/main.py in
the debug mode
+ # because fastapi dev command does not accept any additional arguments
+ # so environment variable is being used to pass it
+ os.environ["AIRFLOW_API_APPS"] = apps
Review Comment:
Going to keep the same for now, might revisit later. Created a draft issue:
https://github.com/orgs/apache/projects/405/views/1?pane=issue&itemId=83765339
> Instead of doing this (adding and then poping), you can just add the
variable to the command like with `AIRFLOW_API_APPS=apps` in the command line
arguments I think.
>
> Both are fine, not blocking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
