TobKed commented on a change in pull request #6096: [AIRFLOW-5477] Rewrite Google PubSub Hook to Google Cloud Python URL: https://github.com/apache/airflow/pull/6096#discussion_r324653411
########## File path: airflow/gcp/hooks/pubsub.py ########## @@ -19,12 +19,18 @@ """ This module contains a Google Pub/Sub Hook. """ -from typing import Any, List, Dict, Optional +from typing import List, Dict, Optional, Sequence, Tuple, Union from uuid import uuid4 -from googleapiclient.discovery import build +from cached_property import cached_property +from google.api_core.retry import Retry +from google.api_core.exceptions import AlreadyExists, GoogleAPICallError +from google.cloud.exceptions import NotFound +from google.cloud.pubsub_v1 import PublisherClient, SubscriberClient +from google.cloud.pubsub_v1.types import Duration, PushConfig, MessageStoragePolicy from googleapiclient.errors import HttpError +from airflow.version import version from airflow.contrib.hooks.gcp_api_base_hook import GoogleCloudBaseHook Review comment: You are right. `_format_subscription` and `_format_topic` are not longer needed. I will delete them. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
