howardyoo commented on PR #43018: URL: https://github.com/apache/airflow/pull/43018#issuecomment-2420833847
> It's a good start. > > * We need to use get_name in all the other methods as well (`decr()`, `gauge()`, etc) which you already said. > * Please add unit tests to make sure the get_name methods you implemented are returning as expected. > * We still need to run the returned name through self.metrics_validator to see if it is on the allow or block list. You could perhaps add that to the abstract class and call super() in the implementation classes, or you could add it back where it was in the individual implemented methods (incr, decr, etc) Yes, I believe implementing unit test on get_name would be required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
