ashb commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports
URL: https://github.com/apache/airflow/pull/5944#discussion_r324712329
 
 

 ##########
 File path: airflow/__init__.py
 ##########
 @@ -23,39 +23,39 @@
 implement their own login mechanisms by providing an `airflow_login` module
 in their PYTHONPATH. airflow_login should be based off the
 `airflow.www.login`
-"""
 
-from typing import Optional, Callable
-from airflow import version
-from airflow.utils.log.logging_mixin import LoggingMixin
+isort:skip_file
 
 Review comment:
   Does this now show up in the API section of the rendered docs?
   
   Is there a reason we are skipping this file but making changes to it? Did 
perhaps we need a blank line first?
   
   ```suggestion
   
   isort:skip_file
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to