Lee-W commented on code in PR #43142:
URL: https://github.com/apache/airflow/pull/43142#discussion_r1806161496


##########
airflow/assets/__init__.py:
##########
@@ -372,6 +372,26 @@ def iter_dag_dependencies(self, *, source: str, target: 
str) -> Iterator[DagDepe
         )
 
 
+class Dataset(Asset):
+    """Subclass of asset."""
+
+    group: str = "dataset"
+
+    def __init__(self, *args, **kwargs) -> None:
+        kwargs["group"] = Dataset.group
+        super().__init__(*args, **kwargs)

Review Comment:
   I'm ok with it being a default. both sounds a big weird to me 🤔 
   
   yep, asset_type would work. I guess the asset_type of the base asset could 
just be "asset"?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to