jason810496 commented on PR #42959:
URL: https://github.com/apache/airflow/pull/42959#issuecomment-2422749143

   
   
   ### Update:
   Hi @pierrejeambrun, the `group_by` resolved the issue. Thanks!
   
   ### Refactor: `SortParm`
   - Moved `attr_mapping` to the `__init__` parameter (since `SortParm` is used 
by different endpoints).
   - Consolidated `allow_attr` with `attr_mapping` (we can use `attr_mapping` 
to validate the query parameters).
   - Added `default_attr` (for models with multiple primary keys, like 
`DagTag`, the original `get_primary_key_column` might not be the column we want 
to sort by. With `default_attr`, we can specify the default field for sorting).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to