Srabasti commented on PR #42577: URL: https://github.com/apache/airflow/pull/42577#issuecomment-2425414099
> I'm not sure whether we would like to include it. Even though rebasing is optional, it's highly recommended. > Same thought Can we all agree to update comments educating code contributors the advantages of Rebasing? Currently, one can commit without rebasing. If we are encouraging users to rebase, even though they can avoid it, better to mention as good standard coding practice to follow. Suggestion is to at least add a one-liner as follows below. Rebasing is highly recommended as a good software practice. Suggested reading to understand advantages of rebasing: https://softwareengineering.stackexchange.com/questions/218801/why-do-so-many-projects-prefer-git-rebase-over-git-merge Please feel free to suggest anything else you would like to add. Thanks in advance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
