potiuk commented on code in PR #43205:
URL: https://github.com/apache/airflow/pull/43205#discussion_r1808528960
##########
scripts/ci/pre_commit/update_installers.py:
##########
@@ -30,8 +30,22 @@
FILES_TO_UPDATE = [
AIRFLOW_SOURCES_ROOT_PATH / "Dockerfile",
AIRFLOW_SOURCES_ROOT_PATH / "Dockerfile.ci",
+ AIRFLOW_SOURCES_ROOT_PATH / "scripts" / "ci" / "install_breeze.sh",
AIRFLOW_SOURCES_ROOT_PATH / "scripts" / "docker" / "common.sh",
AIRFLOW_SOURCES_ROOT_PATH / "pyproject.toml",
+ AIRFLOW_SOURCES_ROOT_PATH / "dev" / "breeze" / "src" / "airflow_breeze" /
"global_constants.py",
+ AIRFLOW_SOURCES_ROOT_PATH
+ / "dev"
+ / "breeze"
+ / "src"
+ / "airflow_breeze"
+ / "commands"
+ / "release_management_commands.py",
+]
+
+
+DOC_FILES_TO_UPDATE: list[Path] = [
Review Comment:
I just wanted to keep it consistent with the "regular" replacement. Even if
technically we do not need it now, it is no harm to keep it this way -
otherwise the two snippets of code (for loops below) would look slightly
different.
I think consistency is a king in this case.
But happy to hear if you disagree with this assessment of course :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
