matschaffer-roblox commented on code in PR #43148:
URL: https://github.com/apache/airflow/pull/43148#discussion_r1814039228
##########
airflow/www/static/js/utils/index.ts:
##########
@@ -169,7 +169,7 @@ interface RunLabelProps {
const getDagRunLabel = ({
dagRun,
- ordering = ["dataIntervalStart", "executionDate"],
+ ordering = ["executionDate"],
}: RunLabelProps) => dagRun[ordering[0]] ?? dagRun[ordering[1]];
Review Comment:
I guess `dagRun` should always have an `executionDate` but seems like you
have an extra risk of `undefined` here since you removed `ordering[1]` from the
default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
