jason810496 commented on issue #42370: URL: https://github.com/apache/airflow/issues/42370#issuecomment-2434047018
Hi @pierrejeambrun, the changes look good to me, but I have another question: When should I utilize a parameter class (the classes declared in `common/parameters.py` with `to_orm` and `depends` methods) instead of adding query parameters directly (like `dag_runs_limit: int = 10` in this case)? For example, in the Event Log endpoints, the query should leverage `paginated_select`, but the `paginated_select` function depends on a parameter class rather than query parameters. In this case, should I declare all filter classes in `common/parameters.py`, or would it be better to add a `FilterParam` with `dynamic_depends`, similar to `SortParam`, that could be used across all endpoints? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
