potiuk commented on code in PR #43383:
URL: https://github.com/apache/airflow/pull/43383#discussion_r1818194588
##########
tests/utils/test_python_virtualenv.py:
##########
@@ -116,25 +116,20 @@ def
test_should_create_virtualenv_with_extra_packages(self, mock_execute_in_subp
mock_execute_in_subprocess.assert_called_with(["/VENV/bin/pip",
"install", "apache-beam[gcp]"])
def test_remove_task_decorator(self):
- py_source = "@task.virtualenv(use_dill=True)\ndef f():\nimport
funcsigs"
+ py_source = "@task.virtualenv(use_dill=True)\ndef f(): ...\nimport
funcsigs"
res = remove_task_decorator(python_source=py_source,
task_decorator_name="@task.virtualenv")
- assert res == "def f():\nimport funcsigs"
+ assert res == "def f():\n ...\nimport funcsigs"
def test_remove_decorator_no_parens(self):
- py_source = "@task.virtualenv\ndef f():\nimport funcsigs"
+ py_source = "@task.virtualenv\ndef f(): ...\nimport funcsigs"
res = remove_task_decorator(python_source=py_source,
task_decorator_name="@task.virtualenv")
- assert res == "def f():\nimport funcsigs"
-
- def test_remove_decorator_including_comment(self):
- py_source = "@task.virtualenv\ndef f():\n# @task.virtualenv\nimport
funcsigs"
- res = remove_task_decorator(python_source=py_source,
task_decorator_name="@task.virtualenv")
- assert res == "def f():\n# @task.virtualenv\nimport funcsigs"
Review Comment:
It's the difference of AST vs. CST.
* (AST) Abstract Syntax Tree - > is the tree of syntax of Python code that
contains only the "meaningful" tokens - that represent a "runtime" python
bytecode (with stripped out comments) -
https://en.wikipedia.org/wiki/Abstract_syntax_tree
* (CST) Concrete Syntax Tree -> is the tree of syntax of Python code that
represent the `source code` - not Python runtime bytecode (that includes EOL
characters and comments, indents and parentheses and punctuation marks) - but
also all other non-runtime tokens - https://en.wikipedia.org/wiki/Parse_tree
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
