eladkal commented on code in PR #42954:
URL: https://github.com/apache/airflow/pull/42954#discussion_r1818846270
##########
providers/src/airflow/providers/amazon/aws/hooks/appflow.py:
##########
@@ -117,9 +117,9 @@ def update_flow_filter(self, flow_name: str, filter_tasks,
set_trigger_ondemand:
self.conn.update_flow(
flowName=response["flowName"],
- destinationFlowConfigList=response["destinationFlowConfigList"],
- sourceFlowConfig=response["sourceFlowConfig"],
- triggerConfig=response["triggerConfig"],
+ destinationFlowConfigList=response["destinationFlowConfigList"],
# type: ignore[arg-type]
+ sourceFlowConfig=response["sourceFlowConfig"], # type:
ignore[arg-type]
+ triggerConfig=response["triggerConfig"], # type: ignore[arg-type]
description=response.get("description", "Flow description."),
- tasks=tasks,
+ tasks=tasks, # type: ignore[arg-type]
Review Comment:
i am not sure if we should just add ignore or fix the actual issue cause id.
We need to check why this was cause failures
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
