bugraoz93 commented on PR #43102: URL: https://github.com/apache/airflow/pull/43102#issuecomment-2442472690
> I think we should also make consistant the behavior for `PATCH` regarding `None` value. > > Here when there is a mask you take them. And when there is no mask, you filter them out. > > I did something different for `Pool` which I think can be extented. When there is a mask, same thing, we use values. When there is no mask, we validate that the payload is valide by it's own, i.e it's a valid db entity by its own, and we use everything. (none or not). > > The idea is to allow someone to not specify `mask` and reset some fields to `None` if needed. I think I looked from the lazy path when no parameter, no value to you :) Saw your changes. Looks good and makes sense! I agree, we should have a common approach for common methods because what we are doing at the end is pretty similar. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
