eladkal commented on PR #43474: URL: https://github.com/apache/airflow/pull/43474#issuecomment-2444177697
Can we maybe change our approach to the default version? We have default value in our hook https://github.com/apache/airflow/blob/0962c285c2659cd86ab436d573f381d928a5fa47/providers/src/airflow/providers/google/ads/hooks/ads.py#L113 https://github.com/apache/airflow/blob/0962c285c2659cd86ab436d573f381d928a5fa47/providers/src/airflow/providers/google/ads/hooks/ads.py#L104 which is forward to the `GoogleAdsClient` https://github.com/apache/airflow/blob/0962c285c2659cd86ab436d573f381d928a5fa47/providers/src/airflow/providers/google/ads/hooks/ads.py#L192 I checked and the client has it's own default. https://github.com/googleads/google-ads-python/blob/6c205c4abdf95a18c70b938e37f448660b280da9/google/ads/googleads/client.py#L35 This means that we can change self.api_version to be default of None. if user wants to set it they can otherwise it uses the underlying SDK default (whatever that may be) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
