o-nikolas commented on code in PR #42081:
URL: https://github.com/apache/airflow/pull/42081#discussion_r1821082105


##########
providers/src/airflow/providers/standard/operators/python.py:
##########
@@ -417,14 +393,15 @@ class _BasePythonVirtualenvOperator(PythonOperator, 
metaclass=ABCMeta):
         "prev_start_date_success",
         "prev_end_date_success",
     }
+
     AIRFLOW_SERIALIZABLE_CONTEXT_KEYS = {
         "macros",
         "conf",
         "dag",
         "dag_run",
         "task",
         "params",
-        "triggering_asset_events",
+        "triggering_asset_events" if AIRFLOW_V_3_0_PLUS else 
"triggering_dataset_events",

Review Comment:
   Why are there dataset events changes in this PR about moving the Python 
Operator?



##########
providers/tests/standard/operators/test_python.py:
##########
@@ -1554,6 +1556,9 @@ def f():
 class TestExternalPythonOperator(BaseTestPythonVirtualenvOperator):
     opcls = ExternalPythonOperator
 
+    def setup_method(self):
+        logging.config.dictConfig(DEFAULT_LOGGING_CONFIG)

Review Comment:
   Why is this required now?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to